Don't throw InexactError for comparisons between FDs of different types and/or Integers #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this PR doesn't address InexactError caused by promotion during arithmetic, e.g.: julia> FixedDecimal{Int8,2}(1) + 2 # Same here: 2 is promoted to FD{Int8,2}(2)
ERROR: InexactError: convert(FixedDecimal{Int8, 2}, 2)I think that's okay for now. If we fixed it, this would either throw an OverflowError anyway if you used checked arithmetic, or it would wrap, using the new semantics. We should probably add support for this, but at least at RAI we're using checked arithmetic for everything so this is going to throw either way and so it seems less urgent to fix it to me. |
mcmcgrath13
reviewed
Dec 19, 2023
mcmcgrath13
reviewed
Dec 19, 2023
mcmcgrath13
reviewed
Dec 19, 2023
|
Thanks for the quick review! Ready for another round 😊 |
mcmcgrath13
approved these changes
Dec 19, 2023
NHDaly
force-pushed
the
nhd-equality-no-inexacts
branch
from
8369395
to
7621196
Compare
|
Thanks Mary. 100% diff coverage now. (That's a really helpful tool.) Here I go! :) I'm gonna also mark this as a patch version bump, since it's a strict improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82.
Before:
After, these all return true. :)
The idea in this PR is to check whether the values would fit in eachother's types, and if not, that's your answer, rather than throwing an InexactError if they fail to promote.